• This topic has prefixes assigned
Viewing 10 posts - 1 through 10 (of 10 total)
Author
Posts
  • #8585

    Hi Nigel,
    I know you are busy! But did you figure out what is wrong with the report in the new version?
    Olde version: http://host-siden.dk/history/module.php?mod=fancy_treeview&mod_action=show&rootid=I1262
    The new version is here: http://host-siden.dk/history-3-3

    You have the login (same for both)

    Regards,
    Jamie Jaconelli

    admin and owner of a user customized version of kiwitrees (contains 3 family trees)

  • #8588

    Not quite, but I am getting close. The new version is much closer to justCarmen’s webtrees code, so the cause is somewhere between her new code and the changes I had to make so it could work in kiwitrees.

    It only effects fairly extreme cases such as your “Historic” GEDCOM file. I’ve yet to find any other example with the same problem. I am aware that justCarmen is also working on a slightly similar bug herself, one that relates only to very large trees with complex relationships. When I get the right time I will discuss it with her. We work very well together.

    It will be fixed before the next release though.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #8604

    For further explanation (can’t remember if I’ve explained this before). The FTV (“descendants” or “Overview”) does work OK in 99.9% of cases.

    Even in the 0.1%, as shown in your example using the GEDCOM file “Historic” you sent me, does still work. The issue is that it is very slow, requiring > 150 seconds (‘max_execution_time’) to produce a result (at least on my servers). That was not an issue in previous versions of kiwitrees, and is not an issue in justCarmen’s webtrees version.

    This is due to complexity of some relationships, not the size of the tree.

    I believe it is due to the new relationship algorithm we are using in kiwitrees. That is the only significant difference between the kiwitrees version of FTV and justCarmen’s original. It was written to make the relationship chart perform better, but (so far) seems to have made FTV slower.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #8605

    Hehe blame the nobility for this. It is a big mess 😛

    Regards,
    Jamie Jaconelli

    admin and owner of a user customized version of kiwitrees (contains 3 family trees)

  • #8642

    kiwi said:

    I believe it is due to the new relationship algorithm we are using in kiwitrees. That is the only significant difference between the kiwitrees version of FTV and justCarmen’s original. It was written to make the relationship chart perform better, but (so far) seems to have made FTV slower.

    I’m sure you’re unlikely to do this Nigel but PLEASE don’t consider moving back from the new relationship algorithm in order to solve this problem. I haven’t mentioned it before but must say it has made an ENORMOUS difference to performance of the relationship chart function on my large DB and a number of my users commented on how the performance improvement made a great difference to the usability of Relationship Chart. Before, for complex relationships, I used to go off to make a coffee while i was waiting for a result. Now it’s virtually instantaneous.

    Ron in France
    Website: https://clan-davies.kiwitrees.net/
    kiwitrees 3.3.9; PHP 7.3.5

  • #8643

    I’m sure you’re unlikely to do this Nigel………

    Don’t worry. There is absolutely no chance of that happening.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #8648

    Jamie

    Attached is a zip file that I think will fix this problem.

    For clarification, it is a bug (introduced by an error of my own) that does effect all sites. But unless you have a very complex tree (containing things like multiple relationships, and very large numbers of generations), you would not notice anything other than a slightly slower page loading. If you have nothing to compare with it would not seem like a bug.

    In the attached zip folder are:

    1. A complete replacement for kiwitrees/modules_v4/fancy_treeview_descendants. Just copy this straight over the existing module.
    2. A replacement for kiwitrees/library/WT/Controller/FancyTreeView.php

    Let me know if it works on your “historic” GEDCOM file OK.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #8701

    Oh I did not getting any email about this. So I have not seen this before now. I am very sorry!

    But YES YES YES it is working 🙂 Thank you!

    Regards,
    Jamie Jaconelli

    admin and owner of a user customized version of kiwitrees (contains 3 family trees)

  • #8702

    I did not getting any email about this.

    You probably need to subscribe to this Bug reporting forum (near top right of the page).

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #8708

    I am a “subber” at this page! Perhabs the page were blocked. I changed the spam setup a while ago! But can see I get them now. But anyhow I did not have the time but I do now 😛

    Regards,
    Jamie Jaconelli

    admin and owner of a user customized version of kiwitrees (contains 3 family trees)

Viewing 10 posts - 1 through 10 (of 10 total)
  • The topic ‘The old fancytreeview’ is closed to new replies.