- This topic has 7 replies, 2 voices, and was last updated 8 years, 4 months ago by
kiwi.
Tags: custom modules simpl_pages
-
22nd July 2015 at 11:55 am #4801
When you updated your copies of simpl_pages you correctly added missing code, but your forgot that sometimes code also just changes or gets removed. You need to do a line-by-line comparison with the current standard module.php and update yours a bit more.
A good tool for doing this almost automatically (it highlights line by line differences and allows you to copy the changes or leave them) is WinMerge. Its free from http://winmerge.org/?lang=en (ver 2.14.0)Once that is done, you should also remove any files or sub-folders from your custom simpl_pages module folder that do not exist in the standard version.
This will improve a few things, but especially it will remove all unnecessary icons from any theme that doesn’t need them.
These changes are largely as a result of making these add-ons part of core code, so they no longer require their own style sheets etc.
You can do all this quite safely without effecting any of your content.
——————————————————————————————————Note: with the current code (even on my own site) using multiple copies of simpl_pages fails HTML validation. This is because each copy uses the menu ID (“menu_mypages”). It doesn’t stop anything from running but can cause issues with some obscure browsers and Search Engine ranking. It is definitely not good practice. I will be fixing this in the next release.
Nigel
My personal kiwitrees site is www.our-families.info -
22nd July 2015 at 1:15 pm #4805
Yes, that should work. But also take any extra files / folders from your copies.
Nigel
My personal kiwitrees site is www.our-families.info -
22nd July 2015 at 2:04 pm #4808
Sorry. I fixed it. I had previously played with the kiwitrees them and just needed to reset it back to yours.
No, you haven’t really fixed it, just hidden the problem.
Your site is still showing errors (trying to link to code that no longer exists) that you really should fix. They are caused by using out-of-date code in your copy modules ‘module.php’ files.
I strongly urge you to continue with your proposal to “grab the latest module.php out of the simpl_pages folder and change the top couple of lines to my module names then overwrite my modules for each book” to avoid future problems.
Nigel
My personal kiwitrees site is www.our-families.info
- The topic ‘Simpl_pages icons’ is closed to new replies.