Posts

If I enter lat-lon for a place (direct, not in Gmaps module) there are four icons to display that on different map services. Bing and mapquest work fine, Google maps does not. Why?

To give more details: new browser tab opens, but the passed url ends with empty brackets () So Gmaps can’t find the coords.

Wow, I didn’t think anyone was still using that old code 🙁

There are two reasons for the issue:

1. Google have changed the URL structure required. Nobody has tested or used this feature in webtrees to my knowledge for so long that it wasnt noticed. I can try to change it, but…
2. Coordinates seem to be a major problem just now for Google. See these discussions: http://productforums.google.com/forum/#!topic/maps/9SpALlpqSeg and http://productforums.google.com/forum/#!topic/maps/Ei5W6yeOTkM

Nigel
My personal kiwitrees site is www.our-families.info

Updated file /includes/functions/functions_print.php attached. This works for now, but it seems Google may yet change the required structure again as they are still developing their “new” Google Map application.

Nigel
My personal kiwitrees site is www.our-families.info

Attachments:

You must be logged in to access attached files.

*** while I was writing an answer kiwi already offered a fix. So maybe ignore my posting ***

Wow, I didn’t think anyone was still using that old code 🙁

(Sorry, I decided to stay with that old code for important coords and use GM module only as a playground.)

Well, it worked some weeks ago. As far as I remember I have had regular wt 1.4.3 at that time.
I’m sure it is not a Google-problem. Just copied the link provided by the little icon:

http://maps.google.com/maps?q=52.444330,13.240376()

This is not working.

http://maps.google.com/maps?q=52.444330,13.240376

That would work. So it’s seems to be the surplus brackets generated by the wt code.

The brackets should have contain the name of the place, and yes that was “part” of the problem.

It also depends if you are using the “Classic” Google Map or the “New” version that is being developed. The Chrome browser has been encouraging users to switch to the new version to test it.

The new code supplied works in both. It changes the url to http://maps.google.com/?q=Sevenoaks&ll=51.278826,0.183874

Nigel
My personal kiwitrees site is www.our-families.info

(Sorry, I decided to stay with that old code for important coords and use GM module only as a playground.)

I presume you realise you have to enter the coordinates for each place EVERY TIME it is used in your data with this old method?
The benefit of the GM module is that each place only needs to be added once – EVER.

Nigel
My personal kiwitrees site is www.our-families.info

One more time:
Thanks a lot, kiwi!

Your fix works fine.

I presume you realise you have to enter the coordinates for each place EVERY TIME it is used in your data with this old method?

Yes. GM module kept me occupied for a long time.

The benefit of the GM module is that each place only needs to be added once – EVER.

No. Due to the specific german history place names changed very often. GM module can’t handle that complexity. Even “normalizing” is not a solution if borders changed a lot.

So for me it is just the other way around: The “old” code is a time-safer for me!
😉 Grimpel

No. Due to the specific german history place names changed very often. GM module can’t handle that complexity.

What makes you think that?

The module is actually very simple, and therefore very flexible. All it does is match GEDCOM place names with a table of place names with coordinates. If there is a match the coordinates will be used and displayed. I know many European places changed borders etc. often. But that is irrelevant to the module.

For example, I have these three places:
Lambeth, London, England
Lambeth, Middlesex, England
Lambeth, Kent, England

They are all physically the same place, but were within different County boundaries at different times in history. So I add Lambeth three times to the GM table, each time linked to a different County (parent level), but always with the same co-ordinates.

You can deal with different spelling in just the same way.

Nigel
My personal kiwitrees site is www.our-families.info