• This topic has 16 replies, 2 voices, and was last updated 8 years ago by pabpab.
Viewing 7 posts - 11 through 17 (of 17 total)
Author
Posts
  • #2650

    While we’re on the subject of the custom_js module, I’d value your opinion on the “clear” button it has.

    Currently it is a simple html input field of type “reset” . That means what it does is to reset the input box back to it’s last saved content.. That is not the same thing as “clearing” or emptying the input box.

    • Do you think that difference is obvious?
    • Should we have both options, or is that unnecessary?
    • Should the button empty the field instead?
    Nigel
    My personal kiwitrees site is www.our-families.info
  • #2651

    The difference is NOT obvious. CLEAR to me means delete everything that was ever in the box. Clearly the button should empty/clear anything in that field … it is not an UNDO … Just EMPTY it. I now copy the text as part of my backup … because I forget where it is in the DB and is not part of GEDCOM.

    Penguins Are  Boss

    https://bootesgowland.kiwitrees.net

    Happy to be hosted by kiwitrees.net

  • #2652

    I tend to agree – but should “clear” also delete the DB contents?

    If it only clears what is visible on screen, then unless you also click “save” then the existing DB content will remain.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #2653

    If you have a moment, can you try the attached replacement for /modules_v3/custom_js/module.php and see if it is any better.

    (By the way – keeping an external text file copy of the custom_js script you use is always a good idea. I do that too.)

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #2655

    I’ve not tried the replacement yet, but after thinking how I tend to do things … I simply highlight the box contents, hit delete key, then save; not using the clear button. Is it really needed?

    Penguins Are  Boss

    https://bootesgowland.kiwitrees.net

    Happy to be hosted by kiwitrees.net

  • #2656

    Maybe, but what you are describing is not necessarily the purpose. Try it first.

    Nigel
    My personal kiwitrees site is www.our-families.info
  • #2660

    I’ve tried the replacement but gone back to the original. Save/Reset/Clear is just overkill for this, surely? I assumed that if I hit ‘clear’ I cleared the text box AND the DB field, and when I hit ‘save’ what is in the text box goes into the DB. Not an issue I’d dwell on.

    Penguins Are  Boss

    https://bootesgowland.kiwitrees.net

    Happy to be hosted by kiwitrees.net

Viewing 7 posts - 11 through 17 (of 17 total)
  • The topic ‘Custom javascript’ is closed to new replies.